Remove the SQL terminator ; from the filter query

jond01 · May 23, 2024 · 1389598 · 1389598
1 parent ea54811
commit 1389598
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/mlrun/model_monitoring/db/tsdb/v3io/v3io_connector.py b/mlrun/model_monitoring/db/tsdb/v3io/v3io_connector.py
@@ -549,7 +549,6 @@ def _get_filter_query(
 
                 query.write(")")
 
-            query.write(";")
             return query.getvalue()
 
     @staticmethod

diff --git a/tests/model_monitoring/test_stores/test_v3io.py b/tests/model_monitoring/test_stores/test_v3io.py
@@ -342,13 +342,13 @@ def test_response_error(cls, store_with_err: KVStoreBase) -> None:
 @pytest.mark.parametrize(
     ("endpoint_id", "names", "expected_query"),
     [
-        ("ddw2lke", [], "endpoint_id='ddw2lke';"),
+        ("ddw2lke", [], "endpoint_id='ddw2lke'"),
         (
             "ep123",
             [("app1", "res1")],
             (
                 "endpoint_id='ep123' "
-                "AND ((application_name='app1' AND result_name='res1'));"
+                "AND ((application_name='app1' AND result_name='res1'))"
             ),
         ),
         (
@@ -358,7 +358,7 @@ def test_response_error(cls, store_with_err: KVStoreBase) -> None:
                 "endpoint_id='ep123' AND "
                 "((application_name='app1' AND result_name='res1') OR "
                 "(application_name='app1' AND result_name='res2') OR "
-                "(application_name='app2' AND result_name='res1'));"
+                "(application_name='app2' AND result_name='res1'))"
             ),
         ),
     ],