Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor publisher connection logic #325

Merged
merged 3 commits into from
Nov 2, 2017
Merged

refactor publisher connection logic #325

merged 3 commits into from
Nov 2, 2017

Conversation

aiomaster
Copy link
Contributor

  • separate connection stuff from publish method to better reuse Sneakers::Publisher for own derived classes
  • fix warning: instance variable @bunny not initialized when connected? is called

@aiomaster
refactor publisher connection logic
be1bb3c 
* separate connection stuff from publish method to better reuse Sneakers::Publisher for own derived classes
* fix warning: instance variable @bunny not initialized when connected? is called
@aiomaster
ensure_connection! should be public
aa9ccbc 
this way we can do something with the connection before publishing
@aiomaster
fix timing issues on integration spec
ac2d572 
* use timeout and retry if expected consumers are not there
* refactor rabbitmq stuff a little in integration spec
@michaelklishin
Copy link
Collaborator

Thanks a lot for ac2d572.

@michaelklishin michaelklishin merged commit f349c9f into jondot:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aiomaster @michaelklishin