First couple of proofreading pages completed. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed superflous commas (when in doubt, leave it out). Removed the Oxford Comma, mostly (lol). Minor grammar to help flow better. Overall this page is in good shape!
Removed superflous dashes like "platform-dependant". Added missing punctuation. Fixed 404 broken link intended to list platforms.
|
This is good stuff, thank you for taking the time to read through. I can feel the flow improving when reading your versions. Mine were a bit more staccato, yours more natural. Apprecated. Cheers! |
jonegil
added a commit
that referenced
this pull request
Feb 20, 2023
First couple of proofreading pages completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW, I'm Geek Stocks in case you're wondering WTF? (That's "WHO the fuck?") lol
I'm not sure when I'll have time again to proofread so I'm submitting these now. Mostly minor stuff; one broken link. I do intend to get to all of the site as I have time.
One important note for you to consider though. The demo at the end of Chapter 1 does not contain an
os.Exit(0)line. When the student clicks the window frame's X to exit the app, the window goes away but the process still hangs in the terminal.Now, you may know that already and it may be intentional for all I know. If it is, I agree with your call, because I'm pretty sure the added complexity to get the
os.Exit(0)line into the right place would defeat the goal of keeping this chapter SIMPLE.BUT, if that IS your reason then my opinion is that you need to do an "information" or "warning" callout at the end of the chapter. The hung process looks bad and makes the project look bad for producing a "failed" demo. Just a sentence or two telling the student that "its intentional" and just use
ctrl-cto exit the process for now. And that you'll fix this issue in Chapter X (I haven't looked but it does get fixed.)Something to think about. I didn't propose anything because I didn't want to presuppose your intentions.