update comment and whats_new.rst

jonescompneurolab · May 31, 2021 · 0f96ef6 · 0f96ef6
1 parent cde4ed2
commit 0f96ef6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/whats_new.rst b/doc/whats_new.rst
@@ -27,7 +27,7 @@ Changelog
 Bug
 ~~~
 
-- Remove repositioning of cells which moves x and z coordinates of all sections slightly, by `Mainak Jas`_ in `#314 <https://github.com/jonescompneurolab/hnn-core/pull/314>`_
+- Remove rounding error caused by repositioning of NEURON cell sections, by `Mainak Jas`_ and `Ryan Thorpe`_ in `#314 <https://github.com/jonescompneurolab/hnn-core/pull/314>`_
 
 API
 ~~~

diff --git a/hnn_core/cell.py b/hnn_core/cell.py
@@ -251,6 +251,8 @@ def _create_sections(self, p_secs, topology):
         whole, but convention is followed in this function ease use of gui.
         """
         # distance from initial to final root postion
+        # Resolve: y-coordinate here corresponds to the z-coordinate in
+        # self.pos[2]
         dx = self.pos[0] - self.p_secs['soma']['sec_pts'][0][0]
         dy = self.pos[2] - self.p_secs['soma']['sec_pts'][0][1]
         dz = self.pos[1] - self.p_secs['soma']['sec_pts'][0][2]