ENH: address ryan comments + simplification

jonescompneurolab · May 5, 2021 · 1ee4a93 · 1ee4a93
1 parent abac3b2
commit 1ee4a93
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/hnn_core/cell.py b/hnn_core/cell.py
@@ -224,7 +224,7 @@ def build(self, p_secs, p_syn, topology, sect_loc):
 
         Parameters
         ----------
-        p_secs : dict
+        p_secs : nested dict
             Dictionary with keys as section name.
             p_secs[sec_name] is a dictionary with keys
             L, diam, Ra, cm, syns and mech.
@@ -307,9 +307,7 @@ def insert_dipole(self, yscale):
 
         # dends must have already been created!!
         # it's easier to use wholetree here, this includes soma
-        sec_list = h.SectionList()
-        sec_list.wholetree(sec=self.sections['soma'])
-        sec_list = [sec for sec in sec_list]
+        sec_list = list(self.sections.values())
         for sect in sec_list:
             sect.insert('dipole')
         # Dipole is defined in dipole_pp.mod

diff --git a/hnn_core/params_default.py b/hnn_core/params_default.py
@@ -440,7 +440,6 @@ def _secs_L2Pyr():
 
 def _secs_L5Pyr():
     """The geometry of the default sections in L5Pyr Neuron."""
-    # Neuron shape based on Jones et al., 2009
     sec_pts = {
         'soma': [[0, 0, 0], [0, 23, 0]],
         'apical_trunk': [[0, 23, 0], [0, 83, 0]],