Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] MAINT: refactor distal/proximal stuff #146

Merged
merged 18 commits into from Aug 28, 2020
Merged

[MRG] MAINT: refactor distal/proximal stuff #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6f71bb6
MAINT: refactor distal/proximal stuff
jasmainak Aug 23, 2020
4169927
FIX pos_src
jasmainak Aug 23, 2020
63530d6
More simplification
jasmainak Aug 23, 2020
c996f6a
MAINT: take method to base _Pyramidal class
jasmainak Aug 23, 2020
8d23a02
Forgotten refactor
jasmainak Aug 23, 2020
b5cd23d
Update hnn_core/pyramidal.py
jasmainak Aug 24, 2020
b2f2f5e
MAINT: _connect_at_loc -> _connect_feed_at_loc
jasmainak Aug 24, 2020
6cd00a8
MAINT: Seeing double?
jasmainak Aug 24, 2020
886cbfe
Flake8
jasmainak Aug 24, 2020
0029d80
MAINT: refactor parreceive and parreceive_ext in pyramidal
jasmainak Aug 25, 2020
5845d17
MAINT: refactor also basket cell
jasmainak Aug 25, 2020
4ca7f42
Addressed ryan's comment but doesn't work
jasmainak Aug 25, 2020
f5c8911
MAINT: monkeypatch Exp2Syn
jasmainak Aug 26, 2020
ece0ecb
Flake8
jasmainak Aug 26, 2020
96c266a
TST for _connect_feed_at_loc
jasmainak Aug 27, 2020
466504b
DOC update whats new
jasmainak Aug 27, 2020
52258f3
DOC: remove comment, values are in accordance to Jones, 2009
jasmainak Aug 27, 2020
1c71219
Define proximal and distal separately for the two classes
jasmainak Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whats_new.rst
View file
Open in desktop
Expand Up @@ -36,6 +36,8 @@ Bug

- Fix bug introduced into rhythmic input feed and add test, by `Christopher Bailey`_ in `#102 <https://github.com/jonescompneurolab/hnn-core/pull/102>`_

- Fix bug in amplitude of delay (for connection between L2 Basket and Gaussian feed) being passed incorrectly, by `Mainak Jas`_ in `#102 <https://github.com/jonescompneurolab/hnn-core/pull/146>`_

API
~~~

Expand Down