Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] BUG: send length of data on MPI child completion #196

Merged
merged 10 commits into from Oct 21, 2020

Commits on Oct 19, 2020

  1. BUG: send length of data on MPI child completion

    Instead of implicitly assuming that all data has been recieved after
    the child process terminates, verify that it matches the expected
    length. This changes the signals between processes to 1) end_of_sim
    and 2) end_of_data:[#bytes]. Upon completion verify that the length
    of the base64 byte string matches this number.
    
    Turns out that padding is necessary. Added back code to only add the
    minimal amount of padding (e.g. '=').
    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    b9f5f2d View commit details
    Browse the repository at this point in the history
  2. MAINT: MPISimulation class

    Refactor mpi_child.py into a proper Python class.
    
    Also reuse _clone_and_simulate() between backends.
    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    455a01a View commit details
    Browse the repository at this point in the history
  3. TST: run tests on mpi_child.py

    - add skip_MPI_import to MPISimulation
    - refactor MPIBackend to separate _process_child_data for testing
    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    04c91e2 View commit details
    Browse the repository at this point in the history
  4. MAINT: no need to test for data padding

    Still raise a custom exception for troubleshooting if it does arise
    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    83a4aa0 View commit details
    Browse the repository at this point in the history
  5. TST: let MPIBackend find number of processors

    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    bf99363 View commit details
    Browse the repository at this point in the history
  6. MAINT: rename skip_MPI_import to skip_mpi_import

    Blake Caldwell committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    d1372c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. MAINT: naming consistency changes

    Blake Caldwell committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    bca0e54 View commit details
    Browse the repository at this point in the history
  2. DOC: update parallel docs for contributors

    Blake Caldwell committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    7a92671 View commit details
    Browse the repository at this point in the history
  3. DOC: add link to parallel_backends to contributing

    Blake Caldwell committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    aed705b View commit details
    Browse the repository at this point in the history
  4. BUG: use initial seed param in _clone_and_simulate

    Use the parameter prng_seedcore_initial
    Blake Caldwell committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    c40ebcd View commit details
    Browse the repository at this point in the history