New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] BUG: send length of data on MPI child completion #196
[MRG] BUG: send length of data on MPI child completion #196
Commits on Oct 19, 2020
-
BUG: send length of data on MPI child completion
Instead of implicitly assuming that all data has been recieved after the child process terminates, verify that it matches the expected length. This changes the signals between processes to 1) end_of_sim and 2) end_of_data:[#bytes]. Upon completion verify that the length of the base64 byte string matches this number. Turns out that padding is necessary. Added back code to only add the minimal amount of padding (e.g. '=').
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for b9f5f2d - Browse repository at this point
Copy the full SHA b9f5f2dView commit details -
Refactor mpi_child.py into a proper Python class. Also reuse _clone_and_simulate() between backends.
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for 455a01a - Browse repository at this point
Copy the full SHA 455a01aView commit details -
TST: run tests on mpi_child.py
- add skip_MPI_import to MPISimulation - refactor MPIBackend to separate _process_child_data for testing
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for 04c91e2 - Browse repository at this point
Copy the full SHA 04c91e2View commit details -
MAINT: no need to test for data padding
Still raise a custom exception for troubleshooting if it does arise
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for 83a4aa0 - Browse repository at this point
Copy the full SHA 83a4aa0View commit details -
TST: let MPIBackend find number of processors
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for bf99363 - Browse repository at this point
Copy the full SHA bf99363View commit details -
MAINT: rename skip_MPI_import to skip_mpi_import
Blake Caldwell committedOct 19, 2020 Configuration menu - View commit details
-
Copy full SHA for d1372c2 - Browse repository at this point
Copy the full SHA d1372c2View commit details
Commits on Oct 20, 2020
-
MAINT: naming consistency changes
Blake Caldwell committedOct 20, 2020 Configuration menu - View commit details
-
Copy full SHA for bca0e54 - Browse repository at this point
Copy the full SHA bca0e54View commit details -
DOC: update parallel docs for contributors
Blake Caldwell committedOct 20, 2020 Configuration menu - View commit details
-
Copy full SHA for 7a92671 - Browse repository at this point
Copy the full SHA 7a92671View commit details -
DOC: add link to parallel_backends to contributing
Blake Caldwell committedOct 20, 2020 Configuration menu - View commit details
-
Copy full SHA for aed705b - Browse repository at this point
Copy the full SHA aed705bView commit details -
BUG: use initial seed param in _clone_and_simulate
Use the parameter prng_seedcore_initial
Blake Caldwell committedOct 20, 2020 Configuration menu - View commit details
-
Copy full SHA for c40ebcd - Browse repository at this point
Copy the full SHA c40ebcdView commit details