Changes read_spikes

[samikane]

This should change the read_spikes function to address issue_178. I'm not sure how to drop the change I made to the testing file, so please get rid of that somehow.

closes #178

[jasmainak]

@samikane next step is to add a unit test :)

[rythorpe]

@samikane my recommendation would be to add a round-trip test to test_network.test_spikes() where you instantiate an empty Spikes object, write it to a temporary file, read it back in, and assert that an empty Spikes object is successfully created. See here for inspiration.

[rythorpe]

This is probably causing your flake8 error.

[ntolley]

Just checked the travis build, there's a couple more issues:

@samikane these should be pretty quick to fix, you can enable flake8 in the settings of your IDE (VS code?) to catch these before pushing. Also if checks are failing you can click on them and look at the traceback to see the errors.

Satisfying flake8 while making the code readable can be more art than science at times...

[jasmainak]

I edited the PR description so it references the original issue.

What's the roadblock here?

[codecov-io]

Codecov Report

Merging #207 (871e4bf) into master (93c79d9) will decrease coverage by 0.05%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   66.85%   66.79%   -0.06%     
==========================================
  Files          21       21              
  Lines        2290     2298       +8     
==========================================
+ Hits         1531     1535       +4     
- Misses        759      763       +4     

Impacted Files	Coverage Δ
hnn_core/network.py	49.63% <0.00%> (-0.73%)	⬇️
hnn_core/tests/test_network.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c79d9...871e4bf. Read the comment docs.

[jasmainak]

@samikane do you still plan to get to this?

I can take over or @rythorpe can if you don't have time

[samikane]

Yeah I think the naming conventions from spike to cell response has changed so I have to change that before making a pr Samika

…

On Dec 22, 2020, at 22:00, Mainak Jas ***@***.***> wrote: @samikane <https://github.com/samikane> do you still plan to get to this? I can take over or @rythorpe <https://github.com/rythorpe> can if you don't have time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#207 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK25LRMQP6XHZGUHJCUDKOTSWFMMPANCNFSM4TWVSWPA>.

[rythorpe]

@jasmainak stay tuned for a few remaining commits following @samikane and my meeting tomorrow.

[samikane]

@jasmainak update to the pull request is ready for your review. We've added a test

[jasmainak]

Diff looks good

Can you update whats_new.rst and fix the flake8. Then I'll merge

[samikane]

@jasmainak should be ready to merge now

[jasmainak]

Looks great, merged. You did it @samikane ! Congratulations 🎉 🍻