New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX extra autapse connection #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 75.92% 81.43% +5.51%
==========================================
Files 12 13 +1
Lines 1383 1406 +23
==========================================
+ Hits 1050 1145 +95
+ Misses 333 261 -72
Continue to review full report at Codecov.
|
# later. Data branch should have only commit so it does not | ||
# pollute the history. | ||
data_url = ('https://raw.githubusercontent.com/jasmainak/' | ||
'mne-neuron/test_data/dpl.txt') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakecaldwell would you mind providing me the dipole text file against which you are testing? I want to add it to the tests so that it doesn't hinder development of mne-neuron once it's fixed. I don't think what I have currently is the correct one ...
Yessss! It works. Now HNN and mne-neuron should be exactly equivalent. Tell me if it's not :) And it won't break in the future thanks to tests. ... and I have some ideas for adding tiny GUI support (not requiring too much maintenance) as well. To make the neuroscientists happy :) Will keep you posted. cc @blakecaldwell @rythorpe |
closes #41
cc @blakecaldwell
This should be equivalent to your fixes here: 8f43e18
can you give it a try?