Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX extra autapse connection #50

Merged
merged 6 commits into from Jun 11, 2019
Merged

FIX extra autapse connection #50

merged 6 commits into from Jun 11, 2019

Conversation

jasmainak
Copy link
Collaborator

@jasmainak jasmainak commented Jun 9, 2019

closes #41

cc @blakecaldwell

This should be equivalent to your fixes here: 8f43e18

can you give it a try?

@codecov-io
Copy link

codecov-io commented Jun 9, 2019

Codecov Report

Merging #50 into master will increase coverage by 5.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   75.92%   81.43%   +5.51%     
==========================================
  Files          12       13       +1     
  Lines        1383     1406      +23     
==========================================
+ Hits         1050     1145      +95     
+ Misses        333      261      -72
Impacted Files Coverage Δ
mne_neuron/basket.py 83.01% <100%> (ø) ⬆️
mne_neuron/tests/test_compare_hnn.py 100% <100%> (ø)
mne_neuron/pyramidal.py 86.95% <100%> (+1.2%) ⬆️
mne_neuron/network.py 77.91% <0%> (+3.75%) ⬆️
mne_neuron/cell.py 82.12% <0%> (+6.7%) ⬆️
mne_neuron/dipole.py 96.11% <0%> (+44.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1841eac...60b7399. Read the comment docs.

# later. Data branch should have only commit so it does not
# pollute the history.
data_url = ('https://raw.githubusercontent.com/jasmainak/'
'mne-neuron/test_data/dpl.txt')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakecaldwell would you mind providing me the dipole text file against which you are testing? I want to add it to the tests so that it doesn't hinder development of mne-neuron once it's fixed. I don't think what I have currently is the correct one ...

@jasmainak jasmainak mentioned this pull request Jun 11, 2019
@jasmainak
Copy link
Collaborator Author

jasmainak commented Jun 11, 2019

Yessss! It works. Now HNN and mne-neuron should be exactly equivalent. Tell me if it's not :) And it won't break in the future thanks to tests.

... and I have some ideas for adding tiny GUI support (not requiring too much maintenance) as well. To make the neuroscientists happy :) Will keep you posted. cc @blakecaldwell @rythorpe

@jasmainak jasmainak merged commit bf2c151 into master Jun 11, 2019
@jasmainak jasmainak deleted the fix_autapse branch June 11, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaling does not match HNN (original)
2 participants