Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scripts to use SF cli instead of SFDX cli #527

Closed
JMercie opened this issue Jul 13, 2023 · 1 comment
Closed

Update Scripts to use SF cli instead of SFDX cli #527

JMercie opened this issue Jul 13, 2023 · 1 comment
Assignees
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger enhancement New feature or request

Comments

@JMercie
Copy link
Contributor

JMercie commented Jul 13, 2023

New Feature Summary

I think would be nice to move to the new SF cli commands as Salesforce is continuously supporting and developing these new cli and commands usually run faster.

I think changes would just be necessary on a few of the pwsh scripts and the package.json scripts.

I can work on it if this feels like a good idea.

@JMercie JMercie added the enhancement New feature or request label Jul 13, 2023
@jongpie
Copy link
Owner

jongpie commented Jul 18, 2023

@JMercie this sounds great to me - I've started using sf myself when doing development, so I think it makes sense to update this repo to use it too. In addition to the pwsh scripts & package.json scripts, there's also the file .github/workflows/build.yml that controls the GitHub pipeline. It looks like I have a few more sfdx commands being called within build.yml that could be update to sf commands instead.

I'd be happy to review & test a PR if you want to work on this. Thanks so much for all of the help!

@jongpie jongpie added the devops Items related to tooling, automation, and guidelines used for developing Nebula Logger label Jul 18, 2023
@jongpie jongpie closed this as completed in 7603057 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Items related to tooling, automation, and guidelines used for developing Nebula Logger enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants