-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issue 527 - update scripts to use @salesforce/cli (SF cli) #532
Solve issue 527 - update scripts to use @salesforce/cli (SF cli) #532
Conversation
@jongpie This PR is ready for review whenever you find time to. Thanks in advance for the time and for any recommendation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JMercie thanks for working on this! I read through the changes, and overall, things look great. There were a few items that I have feedback for - I've added comments about possible changes. Please let me know if you have any questions!
Hey @jongpie Thanks a lot for the feedback on this! I also modified a few other commands beyond the ones you suggested. I used the abbreviature for the parameters; now, every command should use the long version. I reverted the changes in the README.md and create-and-install-package-version.ps1 files, added back the sfdx-cli to the Dev dependencies in the package.json and downgrade the SF cli to 1.87.0 version because until we only want to use the SF cli we won't be able to use the v2 of it. I hope everything looks better, and if you have any further comments on what has to be changed, I will work on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for letting people help on this project and for your review on the work! Looking forward to keep contributing on this project |
As mentioned in issue #527, I updated existing scripts in the repository to use SF CLI instead of SFDX CLI to move to the recommended command line tool for Salesforce development, which is the one getting maintained currently.
Each script was replaced with its SF cli counterpart as detailed in the documentation