Fixed logEntryMetadataViewer 'View Full Source' button not showing for non-admins #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revented the 'view full source' btn from showing up for non-admins 3 parts: Added explicted Apex class access in perm sets to fix some perm issues, fixed some whitespace in the LWC caused by a present-but-not-visible spinner, and updated LWC to imperatively call controller methods (using @wire annotation caused weird, silent failures when calling the Apex methods)
jongpie
added
bug
jongpie
temporarily deployed
to
Experience Cloud Scratch Org
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Base Scratch Org
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 50 50
Lines 5593 5593
=======================================
Hits 5331 5331
Misses 262 262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked with @jamessimone to troubleshoot & fix some additional issues in the
logEntryMetadataViewerLWC that prevented the 'View Full Source' button from showing up for non-admins. This involved 3 related changesLogEntryMetdataViewerControllerto fix some perm issues,@wireannotation caused weird, silent failures when calling the Apex methods