fix(action): fix file key hash calculation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongwooo
approved these changes
Jun 30, 2023
action.yml
Outdated
| @@ -10,7 +10,7 @@ runs: | |||
| path: | | |||
| ${{ github.workspace }}/.next/cache | |||
| key: | | |||
| ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json', '**/npm-shrinkwrap.json', '**/yarn.lock', '**/pnpm-lock.yaml)') }}-${{ hashFiles('**.[jt]s', '**.[jt]sx') }} | |||
| ${{ runner.os }}-nextjs-${{ hashFiles('**/package-lock.json', '**/npm-shrinkwrap.json', '**/yarn.lock', '**/pnpm-lock.yaml)') }}-${{ hashFiles('**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx') }} | |||
There was a problem hiding this comment.
@m1yon Thank you for your contribution:)
2 tasks
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 25, 2023
Hello! I recently tried to cache the `.next/cache` directory in a GitHub action following what was said in the documentation and realized that hashing the source files didn't work properly. This problem also occured in [next-cache](https://github.com/jongwooo/next-cache) and was fixed by [this PR](jongwooo/next-cache#17). This PR simply changes the example from the documentation to apply the same fix (stop using brackets in the patterns passed to `hashFiles`). Hope it helps! ### Improving Documentation - [x] Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - [x] Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the portion of the cache key that caches files isn't matching correctly. Here you can see the last part of the key is empty (current setup):
Changing the blob patterns to more explicit seems to match the files correctly (proposed fix):