Changes to support inline comments, small fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should not remove records by IP during force add, because it may cause other "good" records, one name -> one IP but not vice versa.
|
those comment features are nice! |
lucasfcnunes
added a commit
to lucasfcnunes/python-hosts
that referenced
this pull request
Jun 13, 2021
Answers jonhadfield#20 Retries jonhadfield#10
lucasfcnunes
added a commit
to lucasfcnunes/python-hosts
that referenced
this pull request
Jun 13, 2021
Answers jonhadfield#20 Retries jonhadfield#10 Sorry ;) jonhadfield#35 (comment)
Merged
lucasfcnunes
added a commit
to lucasfcnunes/python-hosts
that referenced
this pull request
Jun 14, 2021
Answers jonhadfield#20 Retries jonhadfield#10 Sorry ;) jonhadfield#35 (comment) *unified commit sorry for the mess...
jonhadfield
pushed a commit
that referenced
this pull request
Feb 27, 2022
Answers #20 Retries #10 Sorry ;) #35 (comment) *unified commit sorry for the mess...
jonhadfield
pushed a commit
that referenced
this pull request
Feb 27, 2022
Answers #20 Retries #10 Sorry ;) #35 (comment) *unified commit sorry for the mess...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Not sure actually if it is useful, making pull request just in case.