-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match up documentation with that from std::collections::HashMap #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a note about the mismatch in parameter ordering between `flurry::HashMap` and `std::collections::HashMap`
This is great! I'll take a look through once I get the chance. Two high-level comments:
|
Oh, the joys of concurrent data structures -- "look ma, no |
jonhoo
reviewed
Feb 3, 2020
jonhoo
reviewed
Feb 3, 2020
jonhoo
reviewed
Feb 3, 2020
jonhoo
reviewed
Feb 3, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
jonhoo
reviewed
Feb 4, 2020
I'm working on fixing the failing address sanitizer stuff in #59 |
jonhoo
approved these changes
Feb 4, 2020
Excellent, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation to match that of std::HashMap, along with simple examples.
The examples make use of
flurry::epoch::pin()
. I don't know if this is still desirable, or if the documentation should make use ofHashMap::guard()
.