Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make style settings for generated flamegraph configurable #16

Closed
13 tasks done
jonhoo opened this issue Feb 2, 2019 · 1 comment · Fixed by #100
Closed
13 tasks done

Make style settings for generated flamegraph configurable #16

jonhoo opened this issue Feb 2, 2019 · 1 comment · Fixed by #100
Labels
enhancement New feature or request good first issue Good for newcomers grab-bag Issues that cover multiple smaller issues help wanted Extra attention is needed

Comments

@jonhoo
Copy link
Owner

jonhoo commented Feb 2, 2019 •
edited
Loading

flamegraph.pl has a lot of configuration arguments, and many of them are there mainly to change the style of the resulting flame graph. We'll leave color schemes do a different issue, but I'm talking about things like

  • imagewidth
  • frameheight
  • fonttype
  • fontsize
  • fontwidth
  • minwidth
  • nametype
  • countname
  • bgcolors (Full color support #32)
  • titletext
  • searchcolor
  • notestext
  • subtitletext

Individually, these should all be pretty easy to add in support for, so we should do it! Even smaller PRs that just add one or two of these are warmly welcome! Try to stick to the flamegraph.pl options where possible.
@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 2, 2019
@jonhoo jonhoo mentioned this issue Feb 4, 2019
Merged
@AnderEnder AnderEnder mentioned this issue Feb 19, 2019
Merged
@jonhoo jonhoo mentioned this issue Feb 22, 2019
Closed
@jonhoo jonhoo added the grab-bag Issues that cover multiple smaller issues label Feb 25, 2019
@jonhoo jonhoo pinned this issue Mar 1, 2019
jonhoo added a commit to AnderEnder/inferno that referenced this issue Mar 13, 2019
@jonhoo
Implement most of flamegraph.pl's style options
cfefd3c 
This PR adds most of the styling options listed in jonhoo#16.
jonhoo pushed a commit that referenced this issue Mar 13, 2019
@jonhoo
Implement most of flamegraph.pl's style options (#52)
0b62604 
This PR adds most of the styling options listed in #16.
@jonhoo
Copy link
Owner Author

jonhoo commented Mar 13, 2019

A bunch of these just landed in #52 thanks to @AnderEnder!

@AnderEnder AnderEnder mentioned this issue Mar 18, 2019
Merged
@jonhoo jonhoo unpinned this issue Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers grab-bag Issues that cover multiple smaller issues help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for --search-color option AnderEnder/inferno
1 participant
@jonhoo