Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Optimize FlameGraphs by utilizing CSS and modern JS from FlameGraph #50

Closed
jbcden opened this issue Feb 17, 2019 · 8 comments · Fixed by #110
Closed

Port Optimize FlameGraphs by utilizing CSS and modern JS from FlameGraph #50

jbcden opened this issue Feb 17, 2019 · 8 comments · Fixed by #110
Labels
adopted Adopting a change from the upstream FlameGraph project enhancement New feature or request help wanted Extra attention is needed

Comments

@jbcden
Copy link

jbcden commented Feb 17, 2019

This issue is to port brendangregg/FlameGraph#189 to inferno. The original author has consented to us porting their work to this project: #26 (comment).
@jonhoo
Copy link
Owner

jonhoo commented Feb 17, 2019

Now that this has been merged upstream too, this should be even easier to land! :D

@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed adopted Adopting a change from the upstream FlameGraph project labels Feb 18, 2019
@jonhoo jonhoo mentioned this issue Feb 20, 2019
Merged
@jonhoo
Copy link
Owner

jonhoo commented Mar 10, 2019

I really want to see this land. @jbcden any chance you might submit a PR for this?

@jbcden
Copy link
Author

jbcden commented Mar 10, 2019

@jonhoo I can try to get something put together this weekend. I do not think I will have time before then though; does that sound alright?

@jonhoo
Copy link
Owner

jonhoo commented Mar 11, 2019

@jbcden that sounds perfect!

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2019

@jbcden gentle ping on this :)

@jbcden
Copy link
Author

jbcden commented Mar 19, 2019

@jonhoo Sorry about the delay! I had some personal stuff come up this weekend and have family coming to visit this week. I will try to open something if I get time, but I may not get to it for a couple of weeks. 😞

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2019

@jbcden No problem at all! Our lives are far more important than some random piece of code on the internet. Enjoy your week+weekend! :D

@jasonrhansen jasonrhansen mentioned this issue Mar 21, 2019
Open
@jasonrhansen
Copy link
Collaborator

@jbcden Last night I was playing around with some of the changes that will be required for this. I could finish it up if you're not already working on it. I don't want to step on your toes. Let me know.

@AnderEnder AnderEnder mentioned this issue Mar 22, 2019
Merged
jonhoo pushed a commit that referenced this issue Mar 24, 2019
@jonhoo
backport modern css js (#110)
84bd1bd 
This patch ports brendangregg/FlameGraph#189 to inferno. The original author
has consented to us porting their work to this project:
#26 (comment).

Fixes #50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adopted Adopting a change from the upstream FlameGraph project enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backport modern css js AnderEnder/inferno
3 participants
@jonhoo @jasonrhansen @jbcden