Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterator interface to that returns structs for each event. #95

Closed
Licenser opened this issue Mar 14, 2019 · 2 comments
Closed

Add iterator interface to that returns structs for each event. #95

Licenser opened this issue Mar 14, 2019 · 2 comments

Comments

@Licenser
Copy link
Contributor

It might be nice to a struct for stacks, an then split it into reader, collapse, 'renderer'

That would allow not having to convert a stack to a string and then back from a string to data to render flame graphs and also generalize the rendering logic.

@jonhoo
Copy link
Owner

jonhoo commented Mar 15, 2019

Are you thinking of something like #30 ?

@Licenser
Copy link
Contributor Author

Abselutely, sorry the topic didn't give it away :) I'll comment on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants