backport original PR198 with states for history #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
approved these changes
Apr 12, 2019
|
The change looks resonable to me, though a 👍 from @versable would be great |
AnderEnder
force-pushed
the
feature/backport-origin-198-history-safe
branch
from
8699295
to
548fa95
Compare
|
Approved ;-) |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 12 12
Lines 1341 1341
=======================================
Hits 1202 1202
Misses 139 139Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #26
It should be tested additionally.
@versable, could you please test and verify?