Add unit tests for JavaScript semantic coloring #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
This looks like a great start, thank you! I think it's likely we'll want to re-use some of that same code for other tests, so perhaps move the struct TestData out of the particular fn you wrote and leave it in the mod tests instead? Apart from that it looks good, and we're really just waiting on CI!
|
Got it! I've just done the requested change! |
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 84.93% 86.16% +1.22%
==========================================
Files 8 8
Lines 737 766 +29
==========================================
+ Hits 626 660 +34
+ Misses 111 106 -5
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some unit tests for Javascript semantic coloring.
#63
Note:
I'm very new into Rust and to your project and I would appreciate any feedback in order to improve!
Thanks!