Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update structopts to 0.3 #145

Merged
merged 2 commits into from Sep 9, 2019
Merged

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k commented Sep 7, 2019

No description provided.

@jonhoo
Copy link
Owner

jonhoo commented Sep 8, 2019

Hmm, this seems to bump the minimum supported Rust version. That's probably fine, but it'd be good if you could find out what it is now updated to, and then set the parameter minrust to that version in azure-pipelines.yml.

@andy128k
Copy link
Contributor Author

andy128k commented Sep 8, 2019

@jonhoo It looks like parameter minrust is set outside of this repo, so, I cannot change it. You need to change it yourself. According to changelog of structopts, minimal supported version is 1.36.

@jonhoo
Copy link
Owner

jonhoo commented Sep 9, 2019

@andy128k I'm not sure I follow? You should be able to just add it below

parameters:
codecov_token: $(CODECOV_TOKEN_SECRET)
single_threaded: true
nightly_coverage: false

with:

minrust: 1.36.0

@jonhoo
Copy link
Owner

jonhoo commented Sep 9, 2019

Looks great, thank you!

@jonhoo jonhoo merged commit 3bd8698 into jonhoo:master Sep 9, 2019
@andy128k andy128k deleted the update_structopts branch September 9, 2019 18:15
@jonhoo
Copy link
Owner

jonhoo commented Sep 11, 2019

Released in 0.9.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants