Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MSRV back to 1.46.0 #220

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Conversation

KnapSac
Copy link
Contributor

@KnapSac KnapSac commented Oct 13, 2021

@KnapSac KnapSac force-pushed the revert-update-rust-version branch 2 times, most recently from 23307d9 to 85fe491 Compare October 13, 2021 08:16
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #220 (85fe491) into master (f62187c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   89.23%   89.20%   -0.04%     
==========================================
  Files          17       17              
  Lines        2351     2352       +1     
==========================================
  Hits         2098     2098              
- Misses        253      254       +1     
Impacted Files Coverage Δ
src/collapse/common.rs 59.32% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62187c...85fe491. Read the comment docs.

@jonhoo
Copy link
Owner

jonhoo commented Oct 17, 2021

Looks like the MSRV failure was due to tkaitchuck/aHash#99, which was fixed again by tkaitchuck/aHash#100. Re-running now, and then I'll merge.

@jonhoo jonhoo merged commit 6f4f95b into jonhoo:master Oct 17, 2021
@KnapSac KnapSac deleted the revert-update-rust-version branch October 19, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants