Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 4 of clap #267

Merged
merged 6 commits into from Feb 11, 2023
Merged

Upgrade to version 4 of clap #267

merged 6 commits into from Feb 11, 2023

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Sep 29, 2022

Replaces #266

This increases MSRV to 1.60.0 (because of clap) when the cli feature is enabled.

@djc
Copy link
Contributor

djc commented Feb 10, 2023

Another reason to adopt 1.60 (or 1.59) might be to get rid of the num_cpus dependency in favor of std::thread::available_parallelism().

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 91.11% // Head: 91.14% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (dab523b) compared to base (044e3ab).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   91.11%   91.14%   +0.03%     
==========================================
  Files          19       19              
  Lines        4219     4236      +17     
==========================================
+ Hits         3844     3861      +17     
  Misses        375      375              
Impacted Files Coverage Δ
src/flamegraph/color/mod.rs 87.39% <ø> (ø)
src/flamegraph/mod.rs 98.22% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2023

Yep, good call-out. I'll merge this and then land that and a fix to #278 separately.

@jonhoo jonhoo merged commit 5fc4f8f into main Feb 11, 2023
@jonhoo jonhoo deleted the clapv4 branch February 11, 2023 21:09
jonhoo added a commit that referenced this pull request Feb 11, 2023
@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2023

Done in #279

@jonhoo
Copy link
Owner Author

jonhoo commented Feb 11, 2023

Released in 0.11.15 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants