Port stackcollapse-recursive.pl #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonriley
changed the title
jonhoo
requested changes
Aug 6, 2023
jonhoo
reviewed
Aug 6, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 91.08% 91.01% -0.07%
==========================================
Files 18 19 +1
Lines 4249 4385 +136
==========================================
+ Hits 3870 3991 +121
- Misses 379 394 +15
☔ View full report in Codecov by Sentry. |
|
Released in 0.11.16 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original script - https://github.com/brendangregg/FlameGraph/blob/master/stackcollapse-recursive.pl
I was a bit unsure whether this fit better as a standalone script or as an option to the existing collapse scripts, but for a first pass I ported this as a standalone script, as
--squash-recursiveoption to one of the other collapse scripts after you decide you want to collapse recursive calls.I can definitely also see benefits to adding this as an option to the existing collapse scripts, so I'm happy to switch to that if you'd prefer!
Fixes #275.