Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #70

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Refactor tests #70

merged 4 commits into from
Mar 7, 2019

Conversation

jasonrhansen
Copy link
Collaborator

No description provided.

src/bin/flamegraph.rs Outdated Show resolved Hide resolved
@jonhoo
Copy link
Owner

jonhoo commented Mar 7, 2019

LGTM subject to those two minor comments.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.03%.
The diff coverage is 97.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #70      +/-   ##
=========================================
+ Coverage   84.77%   84.8%   +0.03%     
=========================================
  Files          13      13              
  Lines        1392    1408      +16     
=========================================
+ Hits         1180    1194      +14     
- Misses        212     214       +2
Impacted Files Coverage Δ
src/bin/flamegraph.rs 0% <0%> (ø) ⬆️
src/flamegraph/mod.rs 97.88% <100%> (+0.03%) ⬆️
src/flamegraph/svg.rs 98.41% <100%> (+0.01%) ⬆️
tests/flamegraph.rs 94.54% <100%> (+0.17%) ⬆️
tests/collapse-perf.rs 95.94% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdad786...0cf7e64. Read the comment docs.

@jasonrhansen jasonrhansen merged commit 3671c0c into jonhoo:master Mar 7, 2019
@jasonrhansen jasonrhansen deleted the refactor-tests branch March 11, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants