Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favorited_by_type and return type #79

Closed
kwent opened this issue May 16, 2019 · 1 comment · Fixed by #82
Closed

favorited_by_type and return type #79

kwent opened this issue May 16, 2019 · 1 comment · Fixed by #82
Labels
bug Something isn't working

Comments

@kwent
Copy link
Contributor

kwent commented May 16, 2019

Hi,

So in 2.1.2 favorited_by_type used to return an active record relationship object and we could do stuff like User.favorited_by_type('Product', scopes: [:foo]).not_deleted.enabled. How do we do this now ?

Now it's returning an array and i didn't see this in the breaking changes changelog AFAIK

Also README says you can pass :limit and :order parameters https://github.com/jonhue/acts_as_favoritor#acts_as_favoritor-methods, but i think that got killed as well.

I filled this as a bug but might a documentation update depending your intentions.

@jonhue
Copy link
Owner

jonhue commented May 17, 2019

This should be an active record relationship object. Good catch! I removed the limit and order options as they are unnecessary then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants