Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop: 0.78.0 → 0.79.0 (major) #127

Merged
merged 1 commit into from Jan 7, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 7, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.78.0 → 0.79.0) · Repo · Changelog

Release Notes

0.79.0

New features

Bug fixes

  • #7193: Prevent Style/PercentLiteralDelimiters from changing %i literals that contain escaped delimiters. (@buehmann)
  • #7590: Fix an error for Layout/SpaceBeforeBlockBraces when using with EnforcedStyle: line_count_based of Style/BlockDelimiters cop. (@koic)
  • #7569: Make Style/YodaCondition accept __FILE__ == $0. (@koic)
  • #7576: Fix an error for Gemspec/OrderedDependencies when using a local variable in an argument of dependent gem. (@koic)
  • #7595: Make Style/NumericPredicate aware of ignored methods when specifying ignored methods. (@koic)
  • #7607: Fix Style/FrozenStringLiteralComment infinite loop when magic comments are newline-separated. (@pirj)
  • #7602: Ensure proper handling of Ruby 2.7 syntax. (@drenmi)
  • #7620: Fix a false positive for Migration/DepartmentName when a disable comment contains a plain comment. (@koic)
  • #7616: Fix an incorrect autocorrect for Style/MultilineWhenThen for when statement with then is an array or a hash. (@koic)
  • #7628: Fix an incorrect autocorrect for Layout/MultilineBlockLayout removing trailing comma with single argument. (@pawptart)
  • #7627: Fix a false negative for Migration/DepartmentName when there is space around : (e.g. # rubocop : disable). (@koic)

Changes

  • #7287: Style/FrozenStringLiteralComment is now considered unsafe. (@buehmann)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 49 commits:

↗️ parser (indirect, 2.6.5.0 → 2.7.0.1) · Repo · Changelog

Release Notes

2.7.0.1 (from changelog)

Bugs fixed:

  • dedenter.rb: prevent ArgumentError when processing binary en… (#642) (Koichi ITO)

2.7.0.0 (from changelog)

API modifications:

  • README.md: documented compatibility issue with EOF chars after… (#637) (Ilya Bylich)
  • ruby27.y: refactor logic around 'circular argument reference'(#628) (Ilya Bylich)

Features implemented:

  • ruby27.y: added pattern matching (#574) (Ilya Bylich)
  • lexer.rl: parse embedded ivars/cvars starting with digit as str (#639) (Ilya Bylich)
  • lexer.rl: warn on ... at EOL. (#636) (Ilya Bylich)
  • ruby27.y: removed opt_block_args_tail: tOROP rule. (#635) (Ilya Bylich)
  • ruby27.y: reverted method reference operator (added in #634) (Ilya Bylich)
  • ruby27.y: treat numparams as locals outside numblock. (#633) (Ilya Bylich)

Bugs fixed:

  • dedenter.rb: fixed over-dedenting of squiggly heredocs (#641) (Ilya Bylich)
  • ruby27.y: added "arguments forwarding" (#625) (Ilya Bylich)
  • ruby27.y: reject circular argument reference. (#622) (Ilya Bylich)
  • ruby27.y: changed prefix of numparams to "_" (#620) (Ilya Bylich)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 19 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 7, 2020
@jonhue jonhue merged commit 137c981 into master Jan 7, 2020
@jonhue jonhue deleted the depfu/update/rubocop-0.79.0 branch January 7, 2020 12:28
@jonhue jonhue mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant