Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't link to specific part of page #67

Open
mark-kraemer opened this issue Feb 25, 2020 · 1 comment
Open

Can't link to specific part of page #67

mark-kraemer opened this issue Feb 25, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mark-kraemer
Copy link

Describe the bug
While using turbolinks animate, the normal browser behavior of linking a specific element on the page from the url breaks

To Reproduce
Steps to reproduce the behavior:

  1. Have turbolinks animate on the page. I currently have document.addEventListener('turbolinks:load', () => TurbolinksAnimate.init()) run in my
  2. Have an element with an id of #some-id down the page
  3. visit http://your-site.com#some-id
  4. It doesn't scroll down to that id
  5. remove the TurbolinksAnimate.init() from the
  6. visit http://your-site.com#some-id
  7. It scrolls down to the part of the page it should as browsers normally do.

Expected behavior
visiting http://your-site.com#some-id should scroll the element with id="some-id" should work by default in browsers

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: chrome
  • Version: 79.0.3945.130
@jonhue jonhue added bug Something isn't working good first issue Good for newcomers labels Mar 3, 2020
@jonhue
Copy link
Owner

jonhue commented Mar 3, 2020

Unfortunately, I don't think that I'll have time to look into this in the next couple of weeks. I'm always happy to review pull requests though 🙂.

@jonhue jonhue added the help wanted Extra attention is needed label Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants