Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework TestBed #105

Merged
merged 2 commits into from
Jul 8, 2023
Merged

feat: rework TestBed #105

merged 2 commits into from
Jul 8, 2023

Conversation

jonisavo
Copy link
Owner

@jonisavo jonisavo commented Jul 8, 2023

Reworks TestBed to work with any class, not just UIComponent. Implements a part of #104.

BREAKING CHANGE: TestBed’s CreateComponent method has been renamed to Instantiate and it no longer takes a factory predicate. Its CreateComponentAsync method has been removed as well as it wasn’t useful in the synchronous Unity Test Framework.
@jonisavo jonisavo added the enhancement New feature or request label Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #105 (9744ed6) into main (ab03ebe) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        54    -1     
  Lines         1631      1613   -18     
=========================================
- Hits          1631      1613   -18     
Flag Coverage Δ
automated 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Assets/UIComponents/Core/UIComponent.cs 100.00% <ø> (ø)
Assets/UIComponents/Testing/TestBed.cs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonisavo jonisavo merged commit aec0cae into main Jul 8, 2023
9 checks passed
@jonisavo jonisavo deleted the feature/reworked-test-bed branch July 8, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant