Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Feed and "All" Group Doesn't Load #193

Closed
SuperSonicHub1 opened this issue Jul 15, 2021 · 13 comments
Closed

[BUG] Feed and "All" Group Doesn't Load #193

SuperSonicHub1 opened this issue Jul 15, 2021 · 13 comments
Labels
bug Something isn't working
Milestone

Comments

@SuperSonicHub1
Copy link

Describe the bug
Fritter errors out on interacting with the Feed tab or All group.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Feed or the All group.
  2. See error.

Screenshots
Feed tab

Device
Google Pixel 3a
Android 11
v2.12.0+20210625

@SuperSonicHub1 SuperSonicHub1 added the bug Something isn't working label Jul 15, 2021
@med93600
Copy link

med93600 commented Jul 15, 2021

Same issue with Xiaomi Poco x3 Android 11 fritter :
v2.12.0+20210625
The behaviour is strange, if I decrease the number of following, the Feed Works.

@SuperSonicHub1
Copy link
Author

Same issue with Xiaomi Poco x3 Android 11 fritter :
v2.12.0+20210625
The behaviour is strange, if I decrease the number of following, the Feed Works.

Do you think it might be an upper limit to the number of profiles that the Twitter API will look up at once?

@med93600
Copy link

Maybe
I'm a New user or fritter, I installed it today
In my all group I have 400 items
I have created a dummy group with about 60 items. Error ! I decreased to 40. Working. And I have increased
Step by step with a max of 66 working. Now I tried to increase but error. But now for exemple 58 items and it doesn't Work
Very strange

@SuperSonicHub1
Copy link
Author

SuperSonicHub1 commented Jul 15, 2021 via email

jonjomckay added a commit that referenced this issue Jul 16, 2021
This improves the displaying and reporting of errored HTTP responses
from Twitter, e.g. when some parameters are incorrect.

Currently they just show as "Instance of 'Response'" which isn't helpful
to the user or developers, and now they report the status code, reason
phrase, error body and request URI.

This should help solve a few open issues, including #82 and #193.
@jonjomckay
Copy link
Owner

Fritter should already be batching large sets of users into different API calls so it doesn't hit the maximum, and I'm not able to reproduce this with a large set of users.

I've just pushed some improvements (d163643) to how these kinds of errors are displayed and reported, which should be going into the next version (v2.13.0). If anyone on this thread is able to download and install the latest development build and either report or screenshot the new errors here, I might be able to fix them ready for the next version!

@SuperSonicHub1
Copy link
Author

SuperSonicHub1 commented Jul 16, 2021 via email

@med93600
Copy link

Hi I have installed the 2.13.0 version
I have this error
Screenshot_2021-07-16-22-33-23-887_com jonjomckay fritter

When I disable "include replies", it Works

@WindHun7er
Copy link

Same problem (issue #82) same error obtained with v2.13.0.

I tried to disable the replies and the all group is working again on my side, but until when (it seems to me that I had already tried this before and the error had finally reappeared... but I may be wrong...)
Strange...

@jonjomckay jonjomckay added this to the v2.14.0 milestone Jul 19, 2021
@jonjomckay
Copy link
Owner

jonjomckay commented Jul 19, 2021

Thanks @med93600 and @WindHun7er (and everyone else who reported and submitted this error) - the new error reporting helped finally track down what was causing this! The Twitter API has a limit of 500 characters when searching, and this bug was causing Fritter to limit to 502 instead, making Twitter throw an (unhelpful, but obvious once you know the problem) error.

The fix will be in v2.14.0 (and the next development build).

@SuperSonicHub1
Copy link
Author

SuperSonicHub1 commented Jul 19, 2021 via email

jonjomckay added a commit that referenced this issue Jul 19, 2021
This fixes a long-standing bug where the logic that paginates feeds with
large numbers of members wasn't correctly limiting the API query length,
causing Twitter to return an "invalid parameters" message.

This would only reproduce with very specific members in groups, as it
needs just one long account name to cause the string to overflow.

I've lowered the string length that forces a new API request, so this
shouldn't happen anymore.

Fixes #82 and #193.
@SuperSonicHub1
Copy link
Author

Same bug with the same 47 error code is popping up again.

@jonjomckay
Copy link
Owner

@SuperSonicHub1 is this still happening, even with the latest version (v2.14.0 or v2.14.1)?

@SuperSonicHub1
Copy link
Author

No, not anymore. I'll close this issue.

weblate pushed a commit to weblate/fritter that referenced this issue Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants