Add support for selecting multiple trends #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add UserTrendLocations as seperate datamodel and dataclass - refactor trendscreen
- user can add trends as a tab to the TrendsScreen - user can remove trends by long-pressing the tab
…nUserTrendsLocations
jonjomckay
force-pushed
the
localtrends_issue_126
branch
from
41f6495
to
cd63e5c
Compare
|
Thanks for this! I'm not too sure on the tab bar, as there's already a horizontal scroll from the page view, but I'll play around with it before v3.0.0 🙂 |
jonjomckay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'd like to contribute to the fritter project, because i use fritter on a daily basis and like the flutter framework. I'm fiddling around with flutter for almost two years and I'm still learning. And I never contributed to a project like this so far...
I picked one Issue, marked as "good first Issue" [#126], for my first contribution.
I added a Tabbar for the TrendsScreen, so the user can add or remove local Trends. I hope it works and you'll like it - if not, I am glad to change things.