Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform absolute file paths to file URI scheme #8

Merged
merged 1 commit into from
Mar 24, 2014
Merged

Transform absolute file paths to file URI scheme #8

merged 1 commit into from
Mar 24, 2014

Commits on Mar 18, 2014

  1. Transform absolute file paths to file URI scheme. 

    On Windows, phantomjs appears to have issues processing relative paths for
referenced files (e.g., script/style refs) when its webpage is created via
an absolute path. I was unable to find a relevant issue on GitHub.

`gulp.src` produces absolute paths in some cases/environments, which will
trigger the above phantomjs issue when using this plugin.

This fix will determine if a file path is absolute and, if so, will
transform it to the file URI scheme (e.g., 'file:///c:/path/to/test.html')
which phantomjs *can* handle. Relative file paths remain untouched.

A test case demonstrating the behaviour was added.
    John Gozde committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    45caf91 View commit details
    Browse the repository at this point in the history