Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar gets cut #465

Closed
alex-vydrin opened this issue Apr 9, 2019 · 8 comments
Closed

Status bar gets cut #465

alex-vydrin opened this issue Apr 9, 2019 · 8 comments

Comments

@alex-vydrin
Copy link

alex-vydrin commented Apr 9, 2019

I'm using the menu Slide Out type, when dragging menu by screen edge pan gesture and release the finger in less then a middle of menu width it goes back (hides), but the status bar gets cut with menuAnimationBackgroundColor from top. The logic for hiding this view is located in SideMenuTransition.hideMenuStart() but it's not called if transition was interrupted and not completed.

Steps to reproduce the behavior:

  1. Set menuAnimationBackgroundColor
  2. Drag the menu by screen edge pan gesture
  3. Release the finger as the menu partly appears on the screen
  4. See the cut of status bar.

In such case (releasing the finger with partly shown menu) should also remove this top inset.

Before dragging menu
IMG_4B2DB0A9C0CF-1

Release the finger during screen edge pan gesture
IMG_92BD7EEB2163-1

Menu is hidden, but the status bar is cut.
IMG_04E79942BFA2-1

Thanks for helping.

@jonkykong
Copy link
Owner

Does this happen in the demo project?

@steveGates890
Copy link

I'm using the menu Slide Out type, when dragging menu by screen edge pan gesture and release the finger in less then a middle of menu width it goes back (hides), but the status bar gets cut with menuAnimationBackgroundColor from top. The logic for hiding this view is located in SideMenuTransition.hideMenuStart() but it's not called if transition was interrupted and not completed.

Steps to reproduce the behavior:

1. Set menuAnimationBackgroundColor

2. Drag the menu by screen edge pan gesture

3. Release the finger as the menu partly appears on the screen

4. See the cut of status bar.

In such case (releasing the finger with partly shown menu) should also remove this top inset.

Before dragging menu
IMG_4B2DB0A9C0CF-1

Release the finger during screen edge pan gesture
IMG_92BD7EEB2163-1

Menu is hidden, but the status bar is cut.
IMG_04E79942BFA2-1

Thanks for helping.

Youv've to just add
SideMenuManager.default.menuFadeStatusBar = false

@alex-vydrin
Copy link
Author

alex-vydrin commented Apr 15, 2019

SideMenuManager.default.menuFadeStatusBar is false. Also this appears in demo @jonkykong :
image
I noticed that it happens when menuAnimationTransformScaleFactor is changed.

@inamsystemsltd
Copy link

Same issue.

@inamsystemsltd
Copy link

@jonkykong any suggestions regarding the issue ?

@steveGates890
Copy link

In demo you only can make SideMenuManager.default.menuFadeStatusBar to make true or false by using UiSwitch state On and Off to perform .

@inamsystemsltd
Copy link

Problem is menuAnimationTransformScaleFactor when we fiddle with that status bar gets disturbed.

@jonkykong
Copy link
Owner

#258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants