Capybara 2.0 support

[razum2um]

There are some API changes. Currently only :selenium is supported (unacceptable on many CI servers and just slower)
More: http://techblog.fundinggates.com/blog/2012/08/capybara-2-0-upgrade-guide/

[joliss]

This is kinda blocking on Capybara's own suite going back to passing reliably.

[kangax]

Would love to have this working!

[joliss]

This is kinda blocking on Capybara's own suite going back to passing reliably.

The test suite should be (mostly) good now. Ping me if there's any flickering issues please. :)

[samwgoldman]

Capybara 2.0 is now released. Currently I am not able to update because Poltergeist depends on Capybara ~> 1.1

[assembler]

+1

[harlow]

Running into the same issue with pessimistic version constraint ~> 1.1. Can it be bumped safely?

[cvincent]

+1!

[Rudikza]

+1

[lucas-clemente]

+1

[BenEddy]

+1

[anlek]

+1

[sapel]

yes please

[joliss]

tl;dr: Please stop posting +1.

Hey guys, I'm on the Capybara core team and I'm subscribed to this issue. That is so I can chime in in case there's stuff I can help with. Every time someone posts +1, I get an email in my inbox. So do several other people. That's actually quite annoying over time. Posting +1 won't make Jon work faster. He's aware that Capybara 2.0 is out, and I'm sure he's planning to work on it.

If you are really in a hurry to get Poltergeist updated, your best bet is to send a pull request.

[mhenrixon]

@jonleighton are you working on this already or should I contribute a pull request?

@joliss I am very surprised you removed all the shared examples for the specs, any suggestions on how to proceed with making the tests pass? I am thinking of the missing files capybara/spec/driver and capybara/spec/session. How do you suggest custom drivers verify expectations without a known interface to test against?

[jonleighton]

@joliss a thousand times +1 to that ;)

@mhenrixon I am not currently working on this. I do of course intend that Poltergeist will support Capybara 2.0, but it's not "omg urgent" for me. 1.1 works perfectly fine. I'd be happy to see a pull request.

[mhenrixon]

@joliss never mind I think I found those examples though I would have appreciated not having to load them all manually :)

[mhenrixon]

@joliss ok so I can't figure it out without some guidance, too many specs failing. :) Get hold of me whenever you have some time to spend on going over what is required.

[brutuscat]

@mhenrixon any updates? I may be able to help you ;) No exp whatsoever with capybara drivers, but I need this too...
@joliss any specific advice on what changed with the 2.0 release at the driver implementation level?

[joliss]

ok so I can't figure it out without some guidance, too many specs failing. :) Get hold of me whenever you have some time to spend on going over what is required.

@mhenrixon, y u no have email address? ;-) Ping me on Skype or email me at joliss42@gmail.com. Maybe we can do some brief remote pairing to get you unstuck.

[brutuscat]

@joliss finally running the specs like you said

Capybara::SpecHelper.run_specs TestSessions::Poltergeist, "Poltergeist"

There're 3 specs failing that I will take care off (hopefully).

In the driver_spec.rb file there are many specs failing. Some because small changes regarding the Session responsibility, but the others seems to be fixed calling the #visit method thought the session instead of the driver. Any comments on that? It is like if calling #visit on the driver it wont make the actual call to the server...

[brutuscat]

Hey guys, as you can see I've submitted a PR #208.

I'm calling for help here to fix a failing spec regarding HTML5 multiple file upload. I tried some stuff but couldn't make it work and ended up not sure about if phantomjs supports this. The spec failing is:

should not break when using HTML5 multiple file input uploading multiple files

I tracked down the relevant code in porltergeist node.rb and browser.coffee. Also found the relevant phanthomjs feature spec at webpage-spec.js and as you can see the test does not asserts what we currently need (and It looks like a bug on their end).

So anyone with more exp in phanthomjs willing to lead me will be great to finish the PR ;)

[jonleighton]

Capybara 2 support was merged, closing.