Manipulate dialog boxes

[znz]

This patch will support to get messages (of window.alert(), window.confirm(), and window.prompt()) and to set responses (for window.confirm() and window.prompt()) using onAlert, onConfirm, and onPrompt of phantomjs.

[jonleighton]

Hi @znz, thanks for the patch.

Ideally I'd like there to be an officially blessed API from Capybara for doing this. Would you be up for working on getting that into Capybara? (cc @jnicklas)

If we don't have an officially blessed API, I think we should at least have the same API as what capybara-webkit has implemented.

Thanks

[jnicklas]

Yes, official API in Capybara is a good idea :)

[gongo]

👍

[gongo]

Good patch! Anyway, implement the same API of capybara-webkit?

[mikepack]

Discussion continued here: https://groups.google.com/forum/?fromgroups=#!topic/ruby-capybara/SLplHkNvZkI

[asross]

Any updates? Sort of waiting for this feature :)

[mikepack]

@asross has not been merged. Trying to determine if headless browsers can support retroactive notification responses. teamcapybara/capybara#1037

[asross]

@mikepack Cool. Thanks for your / everyone else's work on this.

[jonleighton]

I'm going to close this PR for now as it's not going to be merged in its current state. Hopefully everyone here will keep up the good work to develop an official API though, which we can then get into Poltergeist. Thanks.

[gongo]

🎉 Merged Capybara's official API of alert/confirm teamcapybara/capybara#1322

[yaauie]

@gongo yay!

Does anyone want to drive the feature to move us to the newly-merged APIs?

[mikepack]

Cheers!!! 🍺

[gongo]

@yaauie

Does anyone want to drive the feature to move us to the newly-merged APIs?

I'll take it. ok?

[yaauie]

@gongo 👍

[marnen]

@gongo Great! Is there a new pull request?

[gongo]

@marnen

Yes! I will make new PR at a later date.

[yaauie]

@marnen: @gongo just agreed to tackle this ~12 hours ago (and I doubt it's the highest priority in @gongo's life, especially since it's 3:45am UTC+9); please be patient 😄

[marnen]

@yaauie No impatience meant. I was asking if @gongo had been working on an
older existing pull request, not whether he'd suddenly made a pull
request from scratch at 3:45 in the morning. :)

On Thursday, July 3, 2014, Ryan Biesemeyer notifications@github.com wrote:

@marnen https://github.com/marnen: @gongo https://github.com/gongo
just agreed to tackle this ~12 hours ago (and I doubt it's the highest
priority in @gongo https://github.com/gongo's life, especially since
it's 3:45am UTC+9); please be patient [image: 😄]

—
Reply to this email directly or view it on GitHub
#266 (comment)
.

Marnen Laibow-Koser
marnen@marnen.org
http://www.marnen.org

Sent from Gmail Mobile

[gongo]

@yaauie @marnen

Thanks. After taking a sleep well 😴 , I will take little by little 💪