New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildscript for SDL_net #2
base: master
Are you sure you want to change the base?
Conversation
Add the missing escape character before a newline separating a single short-circuit list into two physical lines.
The include file <memory.h> does not exist on the PS3, but just removing the #include line seems to make compilation succeed.
Instead of forcing CFLAGS and LDFLAGS to appropriate values in scripts/003_SDL_image-1.2.10.sh only, do it in make_SDL_Libs.sh so that all packages benefit from it. Also, no LDFLAGS are actually needed anymore...
The mikmod glue in SDL_mixer did not support the new floating point sample formats of SDL 1.3, so add that support.
@@ -0,0 +1,20 @@ | |||
#latest release (1.2.7) doesn't compile against SDL 1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be difficult to patch 1.2.7 to work with SDL 1.3? What kind of incompatibilities are there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. If getting a .tar.gz has value over a 'hg clone' - then one could take a diff between the latest hg version and 1.2.7.
1.2.7 just wouldn't build - I didn't investigate why this was in any detail.
Are there any benefits getting 1.2.7 over the hg repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of pros for getting the 1.2.7 tgz:
- You know exactly what you get (you could probably change the hg checkout to use a tag or something to achieve that as well), and what you get is something which was actually tested as a release, meaning it has a higher level of stability than a random checkout.
- You don't need to have (the exact right version of) autotools installed. Or the hg client, for that matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well SDL_PSL1GHT is from SDL 1.3 so we are already on the bleeding edge. (and this means than SDL_net 1.2.7 is out-of-date for us).
But considering your point about autotools versions - perhaps the a release tar.gz is better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've forked from SDL 1.3 and do not auto-merge from upstream, so no, we are not on the bleeding edge. Not on an actual release either, but at least we know where we are and it is not going to change on its own. ;-)
Hi. I merged this to my fork and fixed the issues I pointed out above. I don't know if jonlimle will ever respond to your request, he didn't to mine... :-/ |
These two libraries are now built by ps3libraries, so we don't need to build them here too.
The source archive for SDL_gfx has a configure.in with a newer timestamp than aclocal.m4. At the same time, the directory "m4" needed for rerunning aclocal is missing. The result is that the Makefile tries to run aclocal-1.10, and if it exists aclocal will bail out because of the missing directory. If aclocal-1.10 is _not_ installed, the old aclocal.m4 is used and all is well. To prevent the build from failing on systems with aclocal-1.10 installed, hide the dependency on configure.in.
Fix SDL_mixer (remove float format that is not in SDL-1.2)
No description provided.