Fix todo in redshift-gtk: toggle_item is checkbox that follows the icon

[maandree]

I have made toggle_item into a CheckMenuItem with the label "Enabled".
Whenever the status is updated toggle_item's active state is set accordingly.
This lead to an loop where setting the active status of toggle_item triggered
the active event that calls toggle_cb which changes the status.
I resolved adding a semaphore (which a thread cannot enter multiple times
concurrently) that is acquired when change the active status if toggle_item,
but also — non-blockingly — around the instructions in toggle_cb.

[jonls]

Thanks, I merged an altered version though. I don't think using semaphores was entirely appropriate when the state could just be checked in toggle_cb().

[maandree]

@jonls While your modification does work, I get an error:

ERROR:root:Could not find any typelib for AppIndicator3
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/redshift_gtk/statusicon.py", line 219, in toggle_cb
    if self.is_enabled() != widget.get_active():
AttributeError: 'StatusIcon' object has no attribute 'get_active'

As indicated by the first line, I do not have AppIndicator,
but I do not think that make a difference.

[jonls]

Good catch. widget should be self.toggle_item since the callback is also called when the StatusIcon is activated.

[hartwork]

@jonls
For the traceback reported by @maandree: is there a patch I can apply or a new release made shortly? Either would help me fixing redshift 1.9 in Gentoo Linux.

[maandree]

Use commit 9426e9f rather than tag v1.9
when fetching the source code tarball.

Or simply apply the diff you get when you click on that link.

[jonls]

@hartwork You can use this as a patch 9426e9f . I'd like to do a 1.9.1 with a few bug fixes, and I think it will be out tomorrow if I can get it done.

[hartwork]

@jonis
Thanks, the patch looks just like what I wanted. Fixed in Gentoo. No extra hurry for a release from my side any more; don't let that stop you though :)