Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GeoClue2 optional at runtime #656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make GeoClue2 optional at runtime #656

wants to merge 2 commits into from

Commits on Aug 15, 2018

  1. geoclue2: fix potential crash in location_geoclue2_free 

    If location_geoclue2_init fails, state->thread and state->lock could be
uninitialized. Ensure that both are always set to avoid a crash.
    @Lekensteyn
    Lekensteyn committed Aug 15, 2018
    Copy the full SHA
    096d153 View commit details
    Browse the repository at this point in the history

  2. geoclue2: ensure fallback to manual mode if unavailable 

    Even if support for GeoClue2 was included at compile time, it could be
missing at runtime. Be sure to check that the service is really
installed.

Tested on Arch Linux without GeoClue2 installed (which results in a
fallback to manual mode) and with GeoClue2 installed (which results in
automatically starting GeoClue2 and using it).
    @Lekensteyn
    Lekensteyn committed Aug 15, 2018
    Copy the full SHA
    688bc05 View commit details
    Browse the repository at this point in the history