Tweak systemd service files to avoid early startup failures #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ci failures on seem to be entirely unrelated to my changes...? |
|
Not sure why CI failed out macOS, but it looks like I can't trigger a re-run myself. Can someone with more permissions trigger one please? |
|
CI should be fixed in master now. Would you be able to rebase? |
added 3 commits
June 14, 2020 11:31
The previous reference (`display-manager.service`) is not something that's included with systemd. While it may be present on some user's system (because they created it, or some specific package includes it), it can't be expected to be present. On the other hand, `graphical-session.target` is included with systemd, and can be expected to be there, and be triggered when starting a graphical session. This guarantees that redshift will only run AFTER a graphic session is up (eg: either Xorg or Wayland are up).
The previous value (`default.target`) meant that redshift got started when a user session began, at which point we can't expect a graphic session to be up and running (eg: Xorg or Wayland may have not even been invoked yet). Setting `WantedBy=graphical-session.target` ensures that, when the service is enable, it'll only get run when starting a graphical session (again, either Xorg or Wayland, whatever DE's may be used).
|
Rebase and passing! ✔️ Happy to see lots of activity again, thanks for maintaining this! |
|
Thanks @WhyNotHugo ! |
|
Does version 1.12-4 include this change? (Using on archlinux) |
Nope. As far as I can see Arch's package is building the last release from the source, and the last release (1.12) is from 2018. I think we need a new release of Redshift finally. |
|
@lukasz-zaroda gammastep includes this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two somewhat similar issues in the systemd service files, that address failures due to redshift starting up too early.
See the commit messages on each commit for further in-depth explanation of both (since they're slightly separate issues, but amount to very similar problems).
Very strongly related to #742, but doesn't entirely fix it.