New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reloading of settings #96
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
… before existing Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
Signed-off-by: Mattias Andrée <maandree@operamail.com>
…ansition Signed-off-by: Mattias Andrée <maandree@operamail.com>
Any chance to get this merged in 2017? Need any help to get this done? |
I'd also love to see this one merged. Is anything blocking this? There hasn't been even a single comment from a maintainer. |
This is a neat feature but I don't think it's useful to most users so I'm not sure if the added complexity is worth merging. It looks like the implementation here doesn't try to handle changes to the adjustment method/location provider. I suspect this is going to lead to confusion if we only reload some parts of the configuration file. In any case, the current PR needs to rebase because the |
@jonls I'd gladly use signal-to-reload config, or even poll-config-file-for-changes. |
I'll describe a usecase that makes this a useful feature. Since Redshift seems to override xrandr settings, e.g. if you change the brightness of your display via This feature would allow changing brightness seamlessly and on the fly. Currently, to change brightness--like if I moved to another room or the lighting changed--I have to kill redshift and restart it with a different brightness, which is a pain. |
This would be very useful on machines with an OLED display where the brightness slider of the OS is not functioning due the lack of a backlight. I would then be able to add key bindings to these brightness buttons to set the Redshift brightness value, and then make Redshift reload the new settings. |
Interested in something like this getting in. Mostly I don't like that terminating redshift spikes my screen color temperature while I'm changing settings. I'd interact with redshift a lot more if I could make changes without blasting myself with blue light. Any help needed here? I'm happy to lend a quick hand. |
I'm trying out xidlehooks, which has the ability to run various hooks on timers at different times. I really like the idea of being able to dim my screen after a few minutes, but this is currently not possible with redshift managed by systemd (see @dbedrenko's comment). I would love some way to do this that doesn't involve a hacky script to to sed the config file, change a setting, then restart the systemd service... I'm not a fan of the blue light flash. I think a socket based client would be ideal. It would allow for easily writing scripts to change color temp, brightness, etc on the fly. That being said, I would be ok with sed scripts to overwrite values if they get automatically picked up. |
The patch enables to user to send SIGUSR2
or use redshift-gtk to load new settings from
redshift.conf. It is configurable whether the
new settings should kick in directly or if there
should be a short transition to them.
Currently only adjustment settings are reloaded,
but this could be extended to include location,
monitors and adjustment method.