add ability to modify display of cluster and namespace #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the context, please see issue #24. As far as the namespace is concerned, im still looking for the best option for aliasing this. |
This was referenced Jun 6, 2018
luisdavim
approved these changes
Oct 27, 2018
|
+1 on the changes from @luisdavim ! |
|
@bradym will you merge this PR? :) looking forward to a release with this hook |
|
I would love to see this merged, I'm working with some clusters that follow a specific naming convention and end up with long names, with these chances I could write a custom function to shorten them by removing specific parts I don't care for... |
|
This change looks good. Hopefully this will help most use cases and we can build upon it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our clusters use a domain-name style naming convention, which makes for a very long prompt when the whole cluster name is used. This PR adds two new variables that can be used to customize the display of the cluster and the namespace using a user-provided function.
I tried to give good explanations on how to use these in the README, please let me know if it's unclear or needs any additional changes.
Thanks!