Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the a statistics field format. #48

Merged
merged 2 commits into from Aug 1, 2019

Conversation

glennslaven
Copy link
Contributor

@glennslaven glennslaven commented Jul 31, 2019

Varnish 4.0.* had the accumulator format which acts as a counter. The code https://github.com/varnishcache/varnish-cache/blob/4.0/include/tbl/vsc_f_main.h#L36 indicates that this was deprecated for c even back then, but varnishstat still exports a number of accumulator values.

Resolves #47

Varnish 4.0.* had the accumulator format which acts as a counter. The code https://github.com/varnishcache/varnish-cache/blob/4.0/include/tbl/vsc_f_main.h#L36 indicates that this was deprecated for `c` even back then, but varnishstat still exports a number of accumulator values.
@glennslaven
Copy link
Contributor Author

Travis build is reporting panic: Log in goroutine after Test_VarnishMetrics_CI has completed.

@jonnenauha jonnenauha merged commit a53fc3a into jonnenauha:master Aug 1, 2019
@jonnenauha
Copy link
Owner

Thanks for work on this. I'll look into the CI failure.

@jonnenauha
Copy link
Owner

Fixed here 9f07234

@jonnenauha
Copy link
Owner

Made a release too if you want to give it a spin in production
https://github.com/jonnenauha/prometheus_varnish_exporter/releases/tag/1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "gauge should be a Counter" when scraping metrics for varnish 4.0
2 participants