Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings with -Wall (and compilation broken if -Werror) #12

Closed
wieckom opened this issue Jul 15, 2013 · 0 comments
Closed

warnings with -Wall (and compilation broken if -Werror) #12

wieckom opened this issue Jul 15, 2013 · 0 comments

Comments

@wieckom
Copy link

wieckom commented Jul 15, 2013

We compile everything with -Wall -Werror.

With current git version of nzmqt it's not possible - there are commas at the end of enums, which lead to

nzmqt-3.2.0-dev/include/nzmqt/nzmqt.hpp:152:32: warning: comma at end of enumerator list [-pedantic]
nzmqt-3.2.0-dev/include/nzmqt/nzmqt.hpp:159:38: warning: comma at end of enumerator list [-pedantic]
nzmqt-3.2.0-dev/include/nzmqt/nzmqt.hpp:166:39: warning: comma at end of enumerator list [-pedantic]
nzmqt-3.2.0-dev/include/nzmqt/nzmqt.hpp:172:39: warning: comma at end of enumerator list [-pedantic]
nzmqt-3.2.0-dev/include/nzmqt/nzmqt.hpp:198:38: warning: comma at end of enumerator list [-pedantic]

Simply removing the last commas in the 5 enums [or 6 if you fix the commented-out one too] fixes it.

$ g++ --version
g++ (GCC) 4.7.1

jonnydee added a commit that referenced this issue Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant