You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should the track_offsets be accessed by track_number or by "track_index"?
The decision in the libdiscid API and in this module currently was, that you should index by track_number and having track_*[0] to be something different a way to achieve this.
A related issue is #23 (Track objects?). That doesn't solve the index problem though.
The text was updated successfully, but these errors were encountered:
Well, a part of the question is: Can the first track be something different than 1?
The standard says "The track numbering shall start with the value 01 and increment by one."
So the first track number is extracted from disc, but it should be 1 for every standard CD and musicbrainz DOES have problems when the first track wouldn't be 1. (I read a bit in the code).
This is one of the reasons why the first track is not discarded, even if it is a data track.
The decision to use
track_offsets[1]
to get the offset for the first track was based ondiscid_get_track_offset(disc, 1)
.This is kind of an 1:1 translation to the libdiscid API, but when using an array
tracks
we have this:tracks[0] corresponds to track_offset[1].
Well, the problem is there anyways, since tracks[0] does have the track number 1.
The question rather is:
What is the least suprise?
or
Should the track_offsets be accessed by track_number or by "track_index"?
The decision in the libdiscid API and in this module currently was, that you should index by track_number and having track_*[0] to be something different a way to achieve this.
A related issue is #23 (Track objects?). That doesn't solve the index problem though.
The text was updated successfully, but these errors were encountered: