Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Logger object immutable #36

Closed
tomkur opened this issue Sep 1, 2016 · 1 comment
Closed

Make Logger object immutable #36

tomkur opened this issue Sep 1, 2016 · 1 comment

Comments

@tomkur
Copy link

tomkur commented Sep 1, 2016

Calls like Logger.WARN = null should be forbidden. How about using Object.freeze?
@jonnyreeves
Copy link
Owner

@tomkur Thanks for the suggestion, I don't have any plans to enforce Object.freeze due to performance issues (although this may no longer be true in 2016 browsers?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnyreeves @tomkur