Update path.js #583
Merged
Update path.js #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small typo in the comment -- I think that start should be stop in line 77. I'm searching for a way to to control where zero is in an ellipse. If I declare an ellipse with this.frontHalf = new Two.Ellipse(0, 0, 0.5, 1); this.frontHalf.beginning = 0 this.frontHalf.ending = 0.5 Then half of the ellipse should show up, but which half? I was hoping for a command like https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/arc Where I could set a start and end angle. Any insights? Will
|
Please ignore my question about the interaction between Ellipse and beginning/ending. I was using an out of date version and since moving to 0.7.13, it works the way I expect! Thanks! Will |
|
Glad to hear and thanks for contributing! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small typo in the comment -- I think that start should be stop in line 77.
I'm searching for a way to to control where zero is in an ellipse. If I declare an ellipse with
this.frontHalf = new Two.Ellipse(0, 0, 0.5, 1);
this.frontHalf.beginning = 0
this.frontHalf.ending = 0.5
Then half of the ellipse should show up, but which half? I was hoping for a command like
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/arc
Where I could set a start and end angle. Any insights?
Will