Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Flagging for Class Names #603

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Improved Flagging for Class Names #603

merged 3 commits into from
Jan 29, 2022

Conversation

jonobr1
Copy link
Owner

@jonobr1 jonobr1 commented Jan 29, 2022

Previously when setting Two.Element.className multiple times the developer could overwrite the flag for sending updates to be rendered like so:

var path = new Two.Path();
path.className = 'foo';
path.className = 'foo';

Because of the way the setter was set up the flag would be updated because the first time it was called it would be set to true. But, the second invocation would show that 'foo' === 'foo' and thus would turn the flag off. This PR fixes that.

@jonobr1 jonobr1 merged commit a6cb8f3 into dev Jan 29, 2022
@jonobr1 jonobr1 deleted the flag-class branch January 29, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant