Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to a Vendor Module #40

Merged
merged 2 commits into from Mar 20, 2018
Merged

Conversion to a Vendor Module #40

merged 2 commits into from Mar 20, 2018

Conversation

UndefinedOffset
Copy link
Contributor

This pull request converts the module to a vendor module which assists with compatibility for 4.1.0 (though it does work fine with 4.0).

@jonom
Copy link
Owner

jonom commented Mar 19, 2018

Thanks @UndefinedOffset. Have been away for a while and don't have time to test this myself right now - I assume you've put this change through the paces?

@UndefinedOffset
Copy link
Contributor Author

Yep also just verified it also works properly through composer using our fork as well. It's exposing the folders as expected and loading properly :)

@UndefinedOffset
Copy link
Contributor Author

Found one issue, looking into will update when I have a fix shouldn't take long just wanted to alert before it's merged.

@UndefinedOffset
Copy link
Contributor Author

And... addressed :) so it's good to go now

@jonom jonom merged commit cd9c208 into jonom:master Mar 20, 2018
@jonom
Copy link
Owner

jonom commented Mar 20, 2018

Thanks!

@adrexia
Copy link

adrexia commented Mar 28, 2018

Awesome! Any chance we could get a release tagged with this in it? :)

@jonom
Copy link
Owner

jonom commented Mar 28, 2018

Oops! Yeah... I guess a minor release should do the trick for this change? It's backwards compatible right?

@adrexia
Copy link

adrexia commented Mar 28, 2018

From what I understand the silverstripe-module type was what kept it out of vendor in the first place. It looks like everyone else has been using minor releases, if that helps? And vendor modules work in 4.0 and 4.1 so it should be fine :)

@jonom
Copy link
Owner

jonom commented Mar 28, 2018

Cool. Have tagged a 4.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants