FocusFill doesn't check wether owner exists

[lerni]

If an Image gets deleted but references still exists, FocusFill & FocusFillMax 'll error like: "Uncaught InvalidArgumentException: Width is required". A check like if ($this->owner->exists()) in FocusFill would prevent this. Would it be aceptable to just wrap the return in such a condition?

[lerni]

probable some more exist-checks are needed to fix #58

https://github.com/jonom/silverstripe-focuspoint/blob/master/src/FieldType/DBFocusPoint.php#L32
https://github.com/jonom/silverstripe-focuspoint/blob/master/src/Forms/FocusPointField.php#L83

[jonom]

Thanks @lerni. Any chance you would like to open a PR to fix this?

[lerni]

Yeah, with pleasure. So you think what I said is the right approach?

[jonom]

I think so, but maybe you could check what the behaviour is for built-in methods. Like if you call Fill instead of FocusFill in the same situation does it fail silently or throw an error? Replicating the native behaviour for consistency is probably the best way to go.

[jonom]

Fixed with #63

[lerni]

thank you @mikenz, somehow just never made it.