-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amending Stage 1 issues #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line PolicyArn='arn:aws:iam::aws:policy/AmazonS3FullAccess'
makes me a sad panda. Can this be modified to just use the s3bucket created by the cloudformation template? you already have the variable name to use in building the policy then applying it to the instance profile role.
Dang it @sonofagl1tch, I tried to get away with being lazy. The attachment is handled by the gewalthaufen, I was running into attachment issues doing it in CFN. One moment while I amend that. |
let me know if you need code to do it. I normally do my cloudformation in json instead of yaml but my detlab shows how do create it all in CFN. |
If you could get it working fully in CFN that would be ideal, then I can remove that last portion from the script which will make it a little faster / less messy. |
ill give it a shot tonight after work and you'll see something tomorrow. |
@sonofagl1tch I am going to merge this PR to take care of the other PFR & BUG and get a fresh one for any CFN changes for the permissions |
Related to PFR #14 and BUG #18