Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending Stage 1 issues #17

Merged
merged 3 commits into from Jun 24, 2020
Merged

Amending Stage 1 issues #17

merged 3 commits into from Jun 24, 2020

Conversation

jonrau1
Copy link
Owner

@jonrau1 jonrau1 commented Jun 23, 2020

Related to PFR #14 and BUG #18

@jonrau1 jonrau1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jun 23, 2020
@jonrau1 jonrau1 self-assigned this Jun 23, 2020
@jonrau1 jonrau1 added this to To-Do in SyntheticSun Roadmap via automation Jun 23, 2020
@jonrau1 jonrau1 moved this from To-Do to Doing in SyntheticSun Roadmap Jun 23, 2020
Copy link
Collaborator

@sonofagl1tch sonofagl1tch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line PolicyArn='arn:aws:iam::aws:policy/AmazonS3FullAccess' makes me a sad panda. Can this be modified to just use the s3bucket created by the cloudformation template? you already have the variable name to use in building the policy then applying it to the instance profile role.

@jonrau1
Copy link
Owner Author

jonrau1 commented Jun 23, 2020

Dang it @sonofagl1tch, I tried to get away with being lazy. The attachment is handled by the gewalthaufen, I was running into attachment issues doing it in CFN. One moment while I amend that.

@sonofagl1tch
Copy link
Collaborator

Dang it @sonofagl1tch, I tried to get away with being lazy. The attachment is handled by the gewalthaufen, I was running into attachment issues doing it in CFN. One moment while I amend that.

let me know if you need code to do it. I normally do my cloudformation in json instead of yaml but my detlab shows how do create it all in CFN.

@jonrau1
Copy link
Owner Author

jonrau1 commented Jun 23, 2020

If you could get it working fully in CFN that would be ideal, then I can remove that last portion from the script which will make it a little faster / less messy.

@sonofagl1tch
Copy link
Collaborator

ill give it a shot tonight after work and you'll see something tomorrow.

@jonrau1 jonrau1 removed their assignment Jun 23, 2020
@jonrau1
Copy link
Owner Author

jonrau1 commented Jun 24, 2020

@sonofagl1tch I am going to merge this PR to take care of the other PFR & BUG and get a fresh one for any CFN changes for the permissions

@jonrau1 jonrau1 merged commit 222947b into master Jun 24, 2020
SyntheticSun Roadmap automation moved this from Doing to Done Jun 24, 2020
@jonrau1 jonrau1 deleted the stage1-improvements-23june branch June 24, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
2 participants